cloud-fan commented on a change in pull request #26678: [SPARK-30226][SQL]
Remove withXXX functions in WriteBuilder
URL: https://github.com/apache/spark/pull/26678#discussion_r357019893
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/StagingTableCatalog.java
##########
@@ -39,9 +40,9 @@
* TABLE AS SELECT operation, if the catalog does not implement this trait,
the planner will first
* drop the table via {@link TableCatalog#dropTable(Identifier)}, then create
the table via
* {@link TableCatalog#createTable(Identifier, StructType, Transform[], Map)},
and then perform
- * the write via {@link
SupportsWrite#newWriteBuilder(CaseInsensitiveStringMap)}. However, if the
- * write operation fails, the catalog will have already dropped the table, and
the planner cannot
- * roll back the dropping of the table.
+ * the write via {@link
SupportsWrite#newWriteBuilder(CaseInsensitiveStringMap, LogicalWriteInfo)}.
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
