rdblue commented on a change in pull request #26817: [SPARK-30192][SQL] support
column position in DS v2
URL: https://github.com/apache/spark/pull/26817#discussion_r357388246
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala
##########
@@ -147,6 +137,25 @@ private[sql] object CatalogV2Util {
replace(schema, update.fieldNames, field =>
Some(field.withComment(update.newComment)))
+ case update: UpdateColumnPosition =>
+ def updateFieldPos(struct: StructType, name: String): StructType = {
+ val oldField = struct.fields.find(_.name == name).getOrElse {
+ throw new IllegalArgumentException("field not found: " + name)
Review comment:
Nit: The first word in an exception message is usually capitalized.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
