MaxGekk commented on a change in pull request #26864: [SPARK-30236][SQL][DOCS] Clarify date and time patterns supported in docs URL: https://github.com/apache/spark/pull/26864#discussion_r357588553
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ########## @@ -595,7 +595,15 @@ case class WeekOfYear(child: Expression) extends UnaryExpression with ImplicitCa // scalastyle:off line.size.limit @ExpressionDescription( - usage = "_FUNC_(timestamp, fmt) - Converts `timestamp` to a value of string in the format specified by the date format `fmt`.", + usage = """ + _FUNC_(timestamp, fmt) - Converts `timestamp` to a value of string in the format specified by the date format `fmt`. + See `java.time.format.DateTimeFormatter` for valid date and time format patterns. + """, + arguments = """ + Arguments: + * timestamp - Date/timestamp or String to be converted to the given format. Default value is current time + * fmt - Date/time format pattern to follow Review comment: Could you move `See `java.time.format.DateTimeFormatter` for valid date and time format patterns.` here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
