MaxGekk commented on a change in pull request #26864: [SPARK-30236][SQL][DOCS] Clarify date and time patterns supported in docs URL: https://github.com/apache/spark/pull/26864#discussion_r357659029
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ########## @@ -655,6 +661,14 @@ case class DateFormatClass(left: Expression, right: Expression, timeZoneId: Opti */ @ExpressionDescription( usage = "_FUNC_(expr[, pattern]) - Returns the UNIX timestamp of the given time.", + arguments = """ + Arguments: + * expr - A date/timestamp or String which is returned as a UNIX timestamp. Review comment: The actual arguments are `timeExp` and `format` but args in the description are `expr` and `pattern`. This confuses slightly. Could you use the same names? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
