yaooqinn commented on a change in pull request #26905: [SPARK-30266][SQL] Avoid match error and int overflow in ApproximatePercentile URL: https://github.com/apache/spark/pull/26905#discussion_r358769512
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala ########## @@ -83,32 +83,32 @@ case class ApproximatePercentile( } // Mark as lazy so that accuracyExpression is not evaluated during tree transformation. - private lazy val accuracy: Int = accuracyExpression.eval().asInstanceOf[Int] + private lazy val accuracy: Long = accuracyExpression.eval().asInstanceOf[Long] Review comment: I checked some, Hive use integrals, presto use decimals(0, 1), oracle, snowflake do not expose accuracy. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
