yaooqinn commented on a change in pull request #26847: [SPARK-30214][SQL] A
new framework to resolve v2 commands
URL: https://github.com/apache/spark/pull/26847#discussion_r361623515
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -210,6 +212,19 @@ object DataSourceV2Strategy extends Strategy with
PredicateHelper {
case AlterNamespaceSetProperties(catalog, namespace, properties) =>
AlterNamespaceSetPropertiesExec(catalog, namespace, properties) :: Nil
+ case CommentOnNamespace(ResolvedNamespace(catalog, namespace), comment) =>
Review comment:
This makes things a bit complicated and inconsistent. With our default
implementation now in session catalog, the reserved props are unremovable
https://github.com/apache/spark/blob/a0057131690b65b73aa6310500039d3a92466324/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala#L230-L235.
If we take null as empty string and update, then the logic between catalogs
can be consistent which also protected by the underlying command
`AlterNamespaceSetPropertiesExec`
https://github.com/apache/spark/blob/c32e2286898fe8660c7deed9303f1c5c15b60757/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/AlterNamespaceSetPropertiesExec.scala#L32-L36
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
