wilfred-s commented on a change in pull request #124: [YUNIKORN-25] Logging
improvements
URL:
https://github.com/apache/incubator-yunikorn-core/pull/124#discussion_r408596503
##########
File path: pkg/scheduler/scheduling_application.go
##########
@@ -393,6 +393,9 @@ func (sa *SchedulingApplication) tryAllocate(headRoom
*resources.Resource, ctx *
for _, request := range sa.sortedRequests {
// resource must fit in headroom otherwise skip the request
if !resources.FitIn(headRoom, request.AllocatedResource) {
+ log.Logger().Debug("skipping allocation because
headroom not enough",
+ zap.String("headRoom", headRoom.String()),
+ zap.String("request",
request.AllocatedResource.String()))
Review comment:
I had this in the code while working on it and found that it was spamming
the logs when there are multiple requests outstanding that can not be satisfied
for a period of time. We could be checking the same requests tens of times per
second.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
