wilfred-s commented on a change in pull request #124: [YUNIKORN-25] Logging
improvements
URL:
https://github.com/apache/incubator-yunikorn-core/pull/124#discussion_r408592673
##########
File path: pkg/scheduler/partition_manager.go
##########
@@ -109,7 +106,8 @@ func (manager partitionManager)
cleanQueues(schedulingQueue *SchedulingQueue) {
}
} else {
// TODO time out waiting for draining and removal
- log.Logger().Debug("failed to remove scheduling queue
due to existing assigned apps or leaf queues",
+ log.Logger().Debug("skip removing the scheduling queue",
+ zap.String("reason", "there are existing
assigned apps or leaf queues"),
Review comment:
we have not used this setup anywhere splitting message into two, not sure
about this but don't mind it either
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
