wilfred-s commented on a change in pull request #124: [YUNIKORN-25] Logging
improvements
URL:
https://github.com/apache/incubator-yunikorn-core/pull/124#discussion_r408592040
##########
File path: pkg/scheduler/partition_manager.go
##########
@@ -86,9 +86,6 @@ func (manager partitionManager) cleanQueues(schedulingQueue
*SchedulingQueue) {
}
// when we have done the children (or have none) this schedulingQueue
might be removable
if schedulingQueue.isDraining() || !schedulingQueue.isManaged() {
- log.Logger().Debug("removing scheduling queue",
- zap.String("queueName", schedulingQueue.Name),
- zap.String("partitionName", manager.psc.Name))
Review comment:
this is the only indication that we are removing a queue without this we
have no idea that it is happening and could hamper debugging
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
