TaoYang526 commented on a change in pull request #117:
URL: 
https://github.com/apache/incubator-yunikorn-k8shim/pull/117#discussion_r428540889



##########
File path: Makefile
##########
@@ -149,7 +149,8 @@ admission: init
 adm_image: admission
        @echo "building admission controller docker images"
        @cp ${ADMISSION_CONTROLLER_BIN_DIR}/${POD_ADMISSION_CONTROLLER_BINARY} 
./deployments/image/admission
-       docker build ./deployments/image/admission -t 
${REGISTRY}/yunikorn:admission-${VERSION}
+       docker build ./deployments/image/admission -t 
${REGISTRY}/yunikorn:admission-${VERSION} \
+         --build-arg DOCKER_IMAGE_REGISTRY=${REGISTRY} 
DOCKER_IMAGE_VERSION=${VERSION}

Review comment:
       It seems that --build-arg can only support one argument so that we can 
add another "--build-arg" before "DOCKER_IMAGE_VERSION=${VERSION}".

##########
File path: Makefile
##########
@@ -149,7 +149,8 @@ admission: init
 adm_image: admission
        @echo "building admission controller docker images"
        @cp ${ADMISSION_CONTROLLER_BIN_DIR}/${POD_ADMISSION_CONTROLLER_BINARY} 
./deployments/image/admission
-       docker build ./deployments/image/admission -t 
${REGISTRY}/yunikorn:admission-${VERSION}
+       docker build ./deployments/image/admission -t 
${REGISTRY}/yunikorn:admission-${VERSION} \

Review comment:
       Just noticed that admission and scheduler are sharing the same repo and 
type(scheduler/admission) is included in the version, is this a common solution 
to make sure they are coming from the same version? 
   I noticed repository is not consistent with the updated scheduler 
repo(${REGISTRY}/yunikorn:scheduler-${VERSION} ), we should update 
helm-charts/values.yaml as the scheduler repo changed, right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to