yangwwei commented on a change in pull request #117:
URL: 
https://github.com/apache/incubator-yunikorn-k8shim/pull/117#discussion_r429042173



##########
File path: Makefile
##########
@@ -149,7 +149,8 @@ admission: init
 adm_image: admission
        @echo "building admission controller docker images"
        @cp ${ADMISSION_CONTROLLER_BIN_DIR}/${POD_ADMISSION_CONTROLLER_BINARY} 
./deployments/image/admission
-       docker build ./deployments/image/admission -t 
${REGISTRY}/yunikorn:admission-${VERSION}
+       docker build ./deployments/image/admission -t 
${REGISTRY}/yunikorn:admission-${VERSION} \

Review comment:
       yes, we need to have them using same repo/version. we have some other 
PRs pending to merge for the repo updates. basically, we are migrating all 
docker images to ASF repo.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to