[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on a change in pull request #117: YUNIKORN-158. Admission controller deployment file should use the same image version as the scheduler

[GitBox]

yangwwei commented on a change in pull request #117:
URL: 
https://github.com/apache/incubator-yunikorn-k8shim/pull/117#discussion_r429041724



##########
File path: Makefile
##########
@@ -149,7 +149,8 @@ admission: init
 adm_image: admission
        @echo "building admission controller docker images"
        @cp ${ADMISSION_CONTROLLER_BIN_DIR}/${POD_ADMISSION_CONTROLLER_BINARY} 
./deployments/image/admission
-       docker build ./deployments/image/admission -t 
${REGISTRY}/yunikorn:admission-${VERSION}
+       docker build ./deployments/image/admission -t 
${REGISTRY}/yunikorn:admission-${VERSION} \
+         --build-arg DOCKER_IMAGE_REGISTRY=${REGISTRY} 
DOCKER_IMAGE_VERSION=${VERSION}

Review comment:
       Ah, good catch. I only tested 1 arg I guess. Let me fix this, thanks!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org