yangwwei commented on a change in pull request #152: URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/152#discussion_r453167049
########## File path: deployments/yunikorn-application/application-definition.yaml ########## @@ -0,0 +1,71 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Deprecated in v1.16 in favor of apiextensions.k8s.io/v1 +apiVersion: apiextensions.k8s.io/v1beta1 +kind: CustomResourceDefinition +metadata: + # name must match the spec fields below, and be in the form: <plural>.<group> + name: applications.yunikorn.apache.org +spec: + # group name to use for REST API: /apis/<group>/<version> + group: yunikorn.apache.org + # list of versions supported by this CustomResourceDefinition + versions: + - name: v1alpha1 + # Each version can be enabled/disabled by Served flag. + served: true + # One and only one version must be marked as the storage version. + storage: true + # either Namespaced or Cluster + scope: Namespaced + names: + # plural name to be used in the URL: /apis/<group>/<version>/<plural> + plural: applications + # singular name to be used as an alias on the CLI and for display + singular: application + # kind is normally the CamelCased singular type. Your resource manifests use this. + kind: Application + # shortNames allow shorter string to match your resource on the CLI + shortNames: + - app + validation: + openAPIV3Schema: + type: object + properties: + spec: + type: object + properties: + minMember: Review comment: 1. this is an optional field 2. it should be an integer ########## File path: deployments/yunikorn-application/application-definition.yaml ########## @@ -0,0 +1,71 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Deprecated in v1.16 in favor of apiextensions.k8s.io/v1 +apiVersion: apiextensions.k8s.io/v1beta1 +kind: CustomResourceDefinition +metadata: + # name must match the spec fields below, and be in the form: <plural>.<group> + name: applications.yunikorn.apache.org +spec: + # group name to use for REST API: /apis/<group>/<version> + group: yunikorn.apache.org + # list of versions supported by this CustomResourceDefinition + versions: + - name: v1alpha1 + # Each version can be enabled/disabled by Served flag. + served: true + # One and only one version must be marked as the storage version. + storage: true + # either Namespaced or Cluster + scope: Namespaced + names: + # plural name to be used in the URL: /apis/<group>/<version>/<plural> + plural: applications + # singular name to be used as an alias on the CLI and for display + singular: application + # kind is normally the CamelCased singular type. Your resource manifests use this. + kind: Application + # shortNames allow shorter string to match your resource on the CLI + shortNames: + - app + validation: + openAPIV3Schema: Review comment: we need to add more validation based on the schema currently, it only defines a type, that's not enough ########## File path: deployments/yunikorn-application/application-definition.yaml ########## @@ -0,0 +1,71 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Deprecated in v1.16 in favor of apiextensions.k8s.io/v1 +apiVersion: apiextensions.k8s.io/v1beta1 +kind: CustomResourceDefinition +metadata: + # name must match the spec fields below, and be in the form: <plural>.<group> + name: applications.yunikorn.apache.org +spec: + # group name to use for REST API: /apis/<group>/<version> + group: yunikorn.apache.org + # list of versions supported by this CustomResourceDefinition + versions: + - name: v1alpha1 + # Each version can be enabled/disabled by Served flag. + served: true + # One and only one version must be marked as the storage version. + storage: true + # either Namespaced or Cluster + scope: Namespaced + names: + # plural name to be used in the URL: /apis/<group>/<version>/<plural> + plural: applications + # singular name to be used as an alias on the CLI and for display + singular: application + # kind is normally the CamelCased singular type. Your resource manifests use this. + kind: Application + # shortNames allow shorter string to match your resource on the CLI + shortNames: + - app + validation: + openAPIV3Schema: + type: object + properties: + spec: + type: object + properties: + minMember: + type: integer + queue: Review comment: 1. this is also an optional field (because the app-CRD is namespace scoped, user can create the CRD under a certain namespace and then leverage our placement rule to place the app to the corresponding queue) 2. it should be complying with the same regex like what defined here: https://github.com/apache/incubator-yunikorn-core/blob/06d2bd9a8b27211749f40caf2d568a0a3ea383d0/pkg/common/configs/configvalidator.go#L43 3. the example should give a full-qualified name, such as `root.default`. ########## File path: deployments/yunikorn-application/application-definition.yaml ########## @@ -0,0 +1,71 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Deprecated in v1.16 in favor of apiextensions.k8s.io/v1 +apiVersion: apiextensions.k8s.io/v1beta1 +kind: CustomResourceDefinition +metadata: + # name must match the spec fields below, and be in the form: <plural>.<group> + name: applications.yunikorn.apache.org +spec: + # group name to use for REST API: /apis/<group>/<version> + group: yunikorn.apache.org + # list of versions supported by this CustomResourceDefinition + versions: + - name: v1alpha1 + # Each version can be enabled/disabled by Served flag. + served: true + # One and only one version must be marked as the storage version. + storage: true + # either Namespaced or Cluster + scope: Namespaced + names: + # plural name to be used in the URL: /apis/<group>/<version>/<plural> + plural: applications + # singular name to be used as an alias on the CLI and for display + singular: application + # kind is normally the CamelCased singular type. Your resource manifests use this. + kind: Application + # shortNames allow shorter string to match your resource on the CLI + shortNames: + - app + validation: + openAPIV3Schema: + type: object + properties: + spec: + type: object + properties: + minMember: + type: integer + queue: + type: string + maxPendingSeconds: + type: integer Review comment: 1. this is also an optional field 2. it is an integer 3. min value 1 (if defined the app will be pending at most X seconds; if not defined, it can be pending forever) ########## File path: deployments/yunikorn-application/sample-yunikorn-app.yaml ########## @@ -0,0 +1,24 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +apiVersion: "yunikorn.apache.org/v1alpha1" +kind: Application +metadata: + name: example Review comment: we need to be careful here. will this field be used as our unique `applicationID`? I guess this name can same across namespaces, correct? so most likely it cannot avoid dup. And in most cases, users may not want to input appID, we should be able to generate one for them. How can we achieve that? Maybe use the object UID? I think we need to think more about these problems before moving forward. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
