kingamarton commented on a change in pull request #152: URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/152#discussion_r453624243
########## File path: deployments/yunikorn-application/sample-yunikorn-app.yaml ########## @@ -0,0 +1,24 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +apiVersion: "yunikorn.apache.org/v1alpha1" +kind: Application +metadata: + name: example Review comment: An another idea is to build the applicationID from the namespace + name. When querying the application in case of a status update we need to provide the namespace and the name, but from the core side we will get only the applicationID. If we don't have the name then I would need to list all the apps and find the one with a specific applicationID, but if I can parse the name from the applicationID, it can be queried for a given namespace and name. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
