yangwwei commented on a change in pull request #152: URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/152#discussion_r453930011
########## File path: deployments/yunikorn-application/sample-yunikorn-app.yaml ########## @@ -0,0 +1,24 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +apiVersion: "yunikorn.apache.org/v1alpha1" +kind: Application +metadata: + name: example Review comment: hi @kingamarton According to https://kubernetes.io/docs/concepts/overview/working-with-objects/names/. Object UID should be unique across the cluster. Maybe we can use that as the `applicationID`. That means the user only needs to specify a namespace-unique name for each app-CRD. Also, metadata has `generateName` field, so if the user doesn't specify any name, K8s will generate one with that as the prefix. What do you think about this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
