kingamarton commented on a change in pull request #238:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/238#discussion_r591238948
##########
File path: pkg/cache/placeholder.go
##########
@@ -50,6 +54,10 @@ func newPlaceholder(placeholderName string, app
*Application, taskGroup v1alpha1
},
},
Spec: v1.PodSpec{
+ SecurityContext: &v1.PodSecurityContext{
+ RunAsUser: &runAsUser,
+ RunAsGroup: &runAsGroup,
Review comment:
What is the setting for the firs pod? Wouldn't be better to use the same
setting instead of defining some default user and group?
##########
File path: pkg/cache/placeholder.go
##########
@@ -29,6 +29,10 @@ import (
"github.com/apache/incubator-yunikorn-k8shim/pkg/common/utils"
)
+// MUST: run the placeholder pod as non-root user
+var runAsUser int64 = 1000
+var runAsGroup int64 = 3000
Review comment:
What these values mens? I think we should add some comments to explain
why this values are used
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
