yangwwei commented on a change in pull request #238:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/238#discussion_r592141796
##########
File path: pkg/cache/placeholder.go
##########
@@ -29,6 +29,10 @@ import (
"github.com/apache/incubator-yunikorn-k8shim/pkg/common/utils"
)
+// MUST: run the placeholder pod as non-root user
+var runAsUser int64 = 1000
+var runAsGroup int64 = 3000
Review comment:
I thought I have replied but looks like I forgot to hit the send button.
I have added the comments, hopefully that explains things.
The reason to just put 1000/3000 is to follow the recommendation from the
K8s security context doc, I think that should be fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
