wilfred-s commented on a change in pull request #238:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/238#discussion_r592138151
##########
File path: pkg/cache/placeholder.go
##########
@@ -29,6 +29,10 @@ import (
"github.com/apache/incubator-yunikorn-k8shim/pkg/common/utils"
)
+// MUST: run the placeholder pod as non-root user
+var runAsUser int64 = 1000
+var runAsGroup int64 = 3000
Review comment:
The IDs are just random user and group IDs. The IDs do not have to map
to real users in the password file etc. Probably better if they do not. IDs
1000 and above are used by OS tools like `useradd` when adding end users.
Anything below that is considered a system account. The linux spec defines a
smaller range from 0-499 for the OS, however 1000 is a safer base.
The only thing I would do is keep user and group ID the same: both 1000. The
comment seems clear enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
