craigcondit commented on a change in pull request #323:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/323#discussion_r710188192
##########
File path: pkg/scheduler/partition.go
##########
@@ -149,7 +149,7 @@ func (pc *PartitionContext) updateNodeSortingPolicy(conf
configs.PartitionConfig
log.Logger().Info("NodeSorting policy set from config",
zap.String("policyName", configuredPolicy.String()))
}
-
pc.nodes.SetNodeSortingPolicy(objects.NewNodeSortingPolicy(conf.NodeSortPolicy.Type))
+
pc.nodes.SetNodeSortingPolicy(objects.NewNodeSortingPolicy(conf.NodeSortPolicy.Type,
conf.NodeSortPolicy.ResourceWeights))
Review comment:
Weights can be arbitrarily large. In fact, I can see circumstances where
negative weights would be useful (for example, you might want to maximize
availability of one resource and minimize another.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
