craigcondit commented on a change in pull request #323:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/323#discussion_r710189650
##########
File path: pkg/scheduler/objects/nodesorting.go
##########
@@ -42,33 +48,79 @@ func (fairnessNodeSortingPolicy) PolicyType()
policies.SortingPolicy {
return policies.FairnessPolicy
}
-func (binPackingNodeSortingPolicy) ScoreNode(node *Node) float64 {
- // choose most loaded node first
- return resources.LargestUsageShare(node.GetAvailableResource())
+func absResourceUsage(node *Node, weights *map[string]float64) float64 {
Review comment:
It isn't calculating a score (though the current scoring algorithms use
it in a similar manner). It's calculating the % of the node's resources that
are in-use (subject to weighting).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
