wilfred-s commented on a change in pull request #397:
URL: https://github.com/apache/yunikorn-core/pull/397#discussion_r837996949
##########
File path: pkg/scheduler/objects/application.go
##########
@@ -142,6 +149,20 @@ func (sa *Application) SetState(state string) {
sa.stateMachine.SetState(state)
}
+func (sa *Application) recordEvent(time time.Time, appState string, prevState
string) {
Review comment:
signature cleanup, make it a simple one argument call:
* time is always passed in as time.Now(), we can set it here. The nano
second differences are not important.
* prevState is not used as the ordering provides the previous state already
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
