craigcondit commented on a change in pull request #397:
URL: https://github.com/apache/yunikorn-core/pull/397#discussion_r838733005



##########
File path: pkg/scheduler/objects/application.go
##########
@@ -53,6 +53,11 @@ const (
        AppTagStateAwareDisable string = "application.stateaware.disable"
 )
 
+type EventLogEntry struct {
+       EventTime        time.Time
+       ApplicationState string
+}

Review comment:
       Updated in new commit.

##########
File path: pkg/scheduler/objects/application.go
##########
@@ -80,6 +85,7 @@ type Application struct {
        gangSchedulingStyle  string                 // gang scheduling style 
can be hard (after timeout we fail the application), or soft (after timeeout we 
schedule it as a normal application)
        finishedTime         time.Time              // the time of finishing 
this application. the default value is zero time
        rejectedMessage      string                 // If the application is 
rejected, save the rejected message
+       eventLog             []*EventLogEntry       // event log for this 
application

Review comment:
       Updated in new commit.

##########
File path: pkg/scheduler/objects/application.go
##########
@@ -142,6 +149,20 @@ func (sa *Application) SetState(state string) {
        sa.stateMachine.SetState(state)
 }
 
+func (sa *Application) recordEvent(time time.Time, appState string, prevState 
string) {

Review comment:
       Updated in new commit.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to