craigcondit commented on a change in pull request #397:
URL: https://github.com/apache/yunikorn-core/pull/397#discussion_r838739876



##########
File path: pkg/scheduler/objects/application.go
##########
@@ -281,6 +303,9 @@ func (sa *Application) timeoutStateTimer(expectedState 
string, event application
                                sa.notifyRMAllocationReleased(sa.rmID, 
toRelease, si.TerminationType_TIMEOUT, "releasing placeholders on app complete")
                                sa.clearStateTimer()
                        } else {
+                               // HandleApplicationEvent assumes the lock to 
be held
+                               sa.Lock()
+                               defer sa.Unlock()

Review comment:
       Opened https://issues.apache.org/jira/browse/YUNIKORN-1164 to address 
these issues.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to