pbacsko commented on code in PR #458:
URL: https://github.com/apache/yunikorn-core/pull/458#discussion_r1035748068
##########
pkg/scheduler/objects/application.go:
##########
@@ -1093,6 +1097,9 @@ func (sa *Application) tryReservedAllocate(headRoom
*resources.Resource, nodeIte
// Do we need a specific node?
if ask.GetRequiredNode() != "" {
+ if ask.HasTriggeredPreemption() ||
time.Since(ask.GetLastPreemptionAttempt()) < sa.preemptionAttemptInterval {
Review Comment:
The is exactly what this change is intended to prevent, ie. once preemption
has been triggered for a given ask, it should not be re-tried again - that's
why we mark requests. Currently, it's possible that we try to terminate the
same set of allocation a dozen times in a second.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
