wilfred-s commented on code in PR #458:
URL: https://github.com/apache/yunikorn-core/pull/458#discussion_r1036955320


##########
pkg/scheduler/objects/application.go:
##########
@@ -1093,6 +1097,9 @@ func (sa *Application) tryReservedAllocate(headRoom 
*resources.Resource, nodeIte
 
                // Do we need a specific node?
                if ask.GetRequiredNode() != "" {
+                       if ask.HasTriggeredPreemption() || 
time.Since(ask.GetLastPreemptionAttempt()) < sa.preemptionAttemptInterval {

Review Comment:
   The delete of the pod should never fail. If it does there is a problem on 
the node. A pod that stays in terminating state  for instance will not get 
removed if we just retry the removal. Sending a second delete will just be 
ignored by the API server as it is already processing a request like it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to