pbacsko commented on code in PR #458:
URL: https://github.com/apache/yunikorn-core/pull/458#discussion_r1035749747


##########
pkg/scheduler/objects/application.go:
##########
@@ -1742,3 +1754,10 @@ func (sa *Application) 
SetTimedOutPlaceholder(taskGroupName string, timedOut int
                sa.placeholderData[taskGroupName].TimedOut = timedOut
        }
 }
+
+// test only
+func (sa *Application) SetPreemptionAttemptInterval(interval time.Duration) {

Review Comment:
   The interval is only considered if there was a preemption attempt for an 
ask, but no victim allocations were found. In this case, we probably want to do 
it again, but not immediately, because we'd flood the logs. If the preemption 
request was successful, then this interval doesn't matter.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to