manirajv06 commented on code in PR #572:
URL: https://github.com/apache/yunikorn-k8shim/pull/572#discussion_r1173311131
##########
test/e2e/simple_preemptor/simple_preemptor_test.go:
##########
@@ -79,13 +81,29 @@ var _ = ginkgo.BeforeSuite(func() {
// Extract node allocatable resources
for _, node := range nodes.Items {
- if node.Name == Worker1 {
+ // skip master if it's marked as such
+ node := node
+ if k8s.IsMasterNode(&node) || !k8s.IsComputeNode(&node) {
Review Comment:
I have seen 3 types - 1. Master 2. Workers 2a). Infra 2b). Compute. We have
to consider only compute nodes, not even 2a for running pods. Once Compute
nodes has been chosen, we have to limit the no. of compute nodes (mostly two)
for running pods and taint other compute nodes as un schedulable based on the
use cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
