craigcondit commented on code in PR #572:
URL: https://github.com/apache/yunikorn-k8shim/pull/572#discussion_r1179871129
##########
test/e2e/simple_preemptor/simple_preemptor_suite_test.go:
##########
@@ -36,17 +35,16 @@ func init() {
func TestSimplePreemptor(t *testing.T) {
ginkgo.ReportAfterSuite("TestSimplePreemptor", func(report
ginkgo.Report) {
- err := common.CreateJUnitReportDir()
- Ω(err).NotTo(gomega.HaveOccurred())
- err = reporters.GenerateJUnitReportWithConfig(
+ err := reporters.GenerateJUnitReportWithConfig(
report,
- filepath.Join(configmanager.YuniKornTestConfig.LogDir,
"TEST-simple_preemptor_junit.xml"),
+ filepath.Join(configmanager.YuniKornTestConfig.LogDir,
"TEST-simple_pre_emptor_junit.xml"),
Review Comment:
Minor nit: Preemptor is one word. WIll fix this on commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
