manirajv06 commented on code in PR #572:
URL: https://github.com/apache/yunikorn-k8shim/pull/572#discussion_r1173318626
##########
test/e2e/simple_preemptor/simple_preemptor_test.go:
##########
@@ -79,13 +81,29 @@ var _ = ginkgo.BeforeSuite(func() {
// Extract node allocatable resources
for _, node := range nodes.Items {
- if node.Name == Worker1 {
+ // skip master if it's marked as such
+ node := node
+ if k8s.IsMasterNode(&node) || !k8s.IsComputeNode(&node) {
+ continue
+ }
+ if Worker1 == "" {
Review Comment:
We need to exclude 1. Master 2. Infra worker nodes and choose only "compute"
worker nodes. Even no. of "compute" worker nodes (mostly two) would be chosen
based on use cases and other remaining "compute" worker nodes would be tainted
as "unschedulable" till we complete the test execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
