zhuqi-lucas commented on code in PR #538:
URL: https://github.com/apache/yunikorn-core/pull/538#discussion_r1227711422
##########
pkg/common/configs/configvalidator.go:
##########
@@ -615,6 +723,13 @@ func Validate(newConfig *SchedulerConfig) error {
if err != nil {
return err
}
+
+ if err = checkLimitResource(partition.Queues[0], nil,
make(map[string]*resources.Resource), make(map[string]*resources.Resource));
err != nil {
Review Comment:
If we can pass the init map, and when return err we clean the map.
When we don't return error, we can reuse the map to limit storage, we don't
need to load from conifg to storage again after this. cc @wilfred-s @pbacsko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
