manirajv06 commented on code in PR #538:
URL: https://github.com/apache/yunikorn-core/pull/538#discussion_r1227899614
##########
pkg/common/configs/configvalidator.go:
##########
@@ -615,6 +723,13 @@ func Validate(newConfig *SchedulerConfig) error {
if err != nil {
return err
}
+
+ if err = checkLimitResource(partition.Queues[0], nil,
make(map[string]*resources.Resource), make(map[string]*resources.Resource));
err != nil {
Review Comment:
We store limits containing max apps and max resources for users and groups
in separate maps. But here, we handle only max resource and max applications in
another method. I am not sure how we can club together and also not sure about
the net gain. If really needed, can we file a follow up jira?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
