pbacsko commented on code in PR #538:
URL: https://github.com/apache/yunikorn-core/pull/538#discussion_r1228229420
##########
pkg/common/utils.go:
##########
@@ -214,3 +214,10 @@ func WaitForCondition(eval func() bool, interval
time.Duration, timeout time.Dur
time.Sleep(interval)
}
}
+
+func Min(x, y uint64) uint64 {
Review Comment:
I might be overly pedantic, but pls add a tiny unit test for this :) (or
move it to `configvalidator.go` if you know that it won't be used by other code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
