manirajv06 commented on PR #673: URL: https://github.com/apache/yunikorn-core/pull/673#issuecomment-1759332060
> Pplease advice if you want tests in this PR, or in follow-up to add tests to cover metric accuracy generally. Yes, we should be doing metrics assertions in all possible places, at least for important state change events in objects like Queues, Application etc. Please file a separate jira. Though no. of changes is going to be high, it is good to do especially given that we are seeing increase in no. of bugs with respect to metrics recently. Can we start with this? It is better to start by making changes in queue_test#TestPendingCalc only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
