Huang-Wei commented on PR #673: URL: https://github.com/apache/yunikorn-core/pull/673#issuecomment-1760887635
> This adds a lot of overhead. The call to updateAllocatedAndPendingResourceMetrics() updates three metrics when it only should do one. Agree. However, the function `updateAllocatedAndPendingResourceMetrics()` and how this pattern is used has been across several releases. In this PR, I followed existing pattern and focus on the **_accuracy_** issue, and try to make it as neat as possible so it's cherrypick-able. For radical performance optimization on how metrics get updated, we should track in a separate JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
