wilfred-s commented on PR #673: URL: https://github.com/apache/yunikorn-core/pull/673#issuecomment-1763712705
> Agree. However, the function updateAllocatedAndPendingResourceMetrics() and how this pattern is used has been across several releases. In this PR, I followed existing pattern and focus on the accuracy issue, and try to make it as neat as possible so it's cherrypick-able. I am also looking at keeping accurate track. We generate metrics entries at a point in time without changes to the underlying values. This could hide the fact that we do not call the metrics at the right time or don't call it for certain changes. They seem accurate in the long run as they are updated as a side effect of another change. This might not show if churn and update rate is high but could show for lower change rates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
