pbacsko commented on code in PR #715:
URL: https://github.com/apache/yunikorn-core/pull/715#discussion_r1393778909
##########
pkg/scheduler/objects/application_test.go:
##########
@@ -1343,6 +1353,9 @@ func TestReplaceAllocationTracking(t *testing.T) {
assert.NilError(t, err, "could not add ask")
app.addPlaceholderDataWithLocking(ph3.GetAsk())
+ // set time to 1 second, in order to test placeholder resource usage
+ time.Sleep(1 * time.Second)
Review Comment:
Why do we have to sleep? I haven't seen this before in the tracking unit
tests.
##########
pkg/scheduler/objects/application.go:
##########
@@ -118,16 +119,17 @@ type Application struct {
}
type ApplicationSummary struct {
- ApplicationID string
- SubmissionTime time.Time
- StartTime time.Time
- FinishTime time.Time
- User string
- Queue string
- State string
- RmID string
- ResourceUsage *resources.TrackedResource
- PreemptedResource *resources.TrackedResource
+ ApplicationID string
+ SubmissionTime time.Time
+ StartTime time.Time
+ FinishTime time.Time
+ User string
+ Queue string
+ State string
+ RmID string
+ ResourceUsage *resources.TrackedResource
+ PreemptedResource *resources.TrackedResource
+ PlaceHolderResource *resources.TrackedResource
Review Comment:
nit: "PlaceHolder" - lowercase "h"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
