zhuqi-lucas commented on code in PR #715:
URL: https://github.com/apache/yunikorn-core/pull/715#discussion_r1393862542
##########
pkg/scheduler/objects/application_test.go:
##########
@@ -1343,6 +1353,9 @@ func TestReplaceAllocationTracking(t *testing.T) {
assert.NilError(t, err, "could not add ask")
app.addPlaceholderDataWithLocking(ph3.GetAsk())
+ // set time to 1 second, in order to test placeholder resource usage
+ time.Sleep(1 * time.Second)
Review Comment:
Thank you, @pbacsko, for review, we sleep for those cases want to count the
resource:
sleepTime * resourceUsageType, so we added those sleep time, and the value
is resourceType * seconds, but we also may find a way to mock it, let me look
into it.
And if we can't mock it, i think we one second is the most time we want to
sleep, 3 seconds is too long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
