pbacsko commented on code in PR #715:
URL: https://github.com/apache/yunikorn-core/pull/715#discussion_r1393778909
##########
pkg/scheduler/objects/application_test.go:
##########
@@ -1343,6 +1353,9 @@ func TestReplaceAllocationTracking(t *testing.T) {
assert.NilError(t, err, "could not add ask")
app.addPlaceholderDataWithLocking(ph3.GetAsk())
+ // set time to 1 second, in order to test placeholder resource usage
+ time.Sleep(1 * time.Second)
Review Comment:
Why do we have to sleep? I haven't seen this before in the tracking unit
tests.
EDIT: I was wrong, I just realized there's time.Sleep() already and it's not
even a small amount, 3 seconds in TestResourceUsageAggregation(). We really
have to think about this... 3 seconds is a lot in a unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
