brandboat opened a new pull request, #748: URL: https://github.com/apache/yunikorn-k8shim/pull/748
### What is this PR for? Fix issue with the placement rules, specifically the one where the provided rule (when `created` is true) is applied before the tag rule, is not functioning as intended. The root cause lies in the GetQueueNameFromPod function in the shim, which automatically adds a default queue name to a pod if none is specified. As a result, the provided rule (when `created` is true) is consistently applied, preventing the tag rule from being triggered. ### What type of PR is it? * [x] - Bug Fix ### Todos N/A ### What is the Jira issue? https://issues.apache.org/jira/browse/YUNIKORN-2230 ### How should this be tested? covered by e2e test ### Screenshots (if appropriate) N/A ### Questions: * [x] - There is breaking changes for older versions. This Pull Request removed the default queue name on the shim side. If a user is using YuniKorn without enabling the Admission Controller (which adds a default queue name), pods that do not provide a queue name will be rejected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
