brandboat commented on PR #748: URL: https://github.com/apache/yunikorn-k8shim/pull/748#issuecomment-1851369962
> This is more a design and behavioural question than a code review. Should we not have a similar behaviour as we have on the admission controller and allow specifying the default queue? In other words should we re-use the setting for the default queue in the K8shim. We do something similar also for the application ID generation. Thank's for the comment! Indeed, that is a better way and doing so won't break anything. I'll make the setting `admissionController.filtering.defaultQueue` to also determine whether K8shim should add the default queue name or not. And we should emphasize in document that this setting still takes effect even without the admission controller, I'll open another pr to do that after this one is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
