brandboat commented on PR #748: URL: https://github.com/apache/yunikorn-k8shim/pull/748#issuecomment-1858060133
gentle ping @wilfred-s I'm trying to follow the logic of `GenerateUniqueAppIds` and add a new variable `DefaultQueueName` in schedulerconf.go. However, I encountered a challenge. I believe DefaultQueueName must be placed in handleNonReloadableConfig to make it a configuration that takes effect only after restarting YuniKorn. Without this, changes to DefaultQueueName might lead to inconsistencies when getAppMetadata returns the queueName in the existing pod, as it could change due to configmap modifications in DefaultQueueName. However, if I set DefaultQueueName as non-reloadable, changing the default queue name to `""` would require restarting the entire YuniKorn. Otherwise, the K8shim might still return the queue name as `root.default` (the current default value of DefaultQueueName). I think this could make things more complex, not unsure if there are better suggestions or approaches... thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
