craigcondit commented on code in PR #757:
URL: https://github.com/apache/yunikorn-core/pull/757#discussion_r1521828425
##########
pkg/webservice/handlers.go:
##########
@@ -1216,3 +1227,40 @@ func getStream(w http.ResponseWriter, r *http.Request) {
}
}
}
+
+func checkHeader(h http.Header, key string, value string) bool {
Review Comment:
> It seems to me following the standard error can avoid the misunderstanding
in the future.
*NO*. We should never return an error to the client if it request an
encoding we don't understand. `Accept-Encoding: identity` is the default, which
means the identity encoding is always allowed. Therefore, if an unacceptable
encoding is requested, we simply send the request uncompressed and without a
`Content-Encoding: gzip` header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
