brandboat commented on code in PR #808: URL: https://github.com/apache/yunikorn-k8shim/pull/808#discussion_r1544597227
########## pkg/common/constants/constants.go: ########## @@ -65,8 +66,7 @@ const DaemonSetType = "DaemonSet" const PlaceholderContainerImage = "registry.k8s.io/pause:3.7" const PlaceholderContainerName = "pause" const PlaceholderPodRestartPolicy = "Never" -const LabelPlaceholderFlag = "placeholder" -const AnnotationPlaceholderFlag = DomainYuniKorn + "placeholder" +const AnnotationPlaceholderFlag = DomainYuniKornInternal + "placeholder" Review Comment: quoted from [Craig's comment in jira](https://issues.apache.org/jira/browse/YUNIKORN-1351?focusedCommentId=17821767&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17821767) > Placeholder flag – used internally by scheduler only, remove documentation > - internal.yunikorn.apache.org/placeholder [annotation] – generate in 1.6.0+ > - yunikorn.apache.org/placeholder [annotation] – parse in 1.6.0, remove in 1.7.0 > - placeholder [label] – parse in 1.6.0, remove in 1.7.0 Not sure if I misunderstand anything, but looks like we remove annotation `yunikorn.apache.org/placeholder` in current version (1.6.0), shouldn't we remove it in next version 1.7.0 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
