chenyulin0719 commented on code in PR #808:
URL: https://github.com/apache/yunikorn-k8shim/pull/808#discussion_r1595352316
##########
test/e2e/framework/helpers/k8s/k8s_utils.go:
##########
@@ -1241,12 +1242,12 @@ func (k *KubeCtl) WaitForPlaceholders(namespace string,
podPrefix string, numPod
func (k *KubeCtl) ListPlaceholders(namespace string, podPrefix string)
([]v1.Pod, error) {
pods := make([]v1.Pod, 0)
- podList, lstErr := k.ListPods(namespace, "placeholder=true")
+ podList, lstErr := k.ListPods(namespace, "")
if lstErr != nil {
return pods, lstErr
}
for _, pod := range podList.Items {
- if strings.HasPrefix(pod.Name, podPrefix) {
+ if strings.HasPrefix(pod.Name, podPrefix) &&
pod.Annotations[constants.AnnotationPlaceholderFlag] == constants.True {
Review Comment:
@chia7712
In 1.6.0, the function GetPlaceholderFlagFromPodSpec() fetch placholder from
pod in below order:
1. internal.yunikorn.apache.org/placeholder
2. yunikorn.apache.org/placeholder (Deprecated Annotation)
3. placeholder (Deprecated Label)
The existing placeholder pod is still considered as placeholder pod in 1.6.0.
I'll remove deprecated placeholder in 1.7.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
