pbacsko commented on code in PR #810:
URL: https://github.com/apache/yunikorn-core/pull/810#discussion_r1545422358
##########
pkg/scheduler/ugm/queue_tracker.go:
##########
@@ -140,12 +136,9 @@ func (qt *QueueTracker) decreaseTrackedResource(hierarchy
[]string, applicationI
if qt.childQueueTrackers[childName] == nil {
log.Log(log.SchedUGM).Error("Child queueTracker tracker
must be available in child queues map",
zap.String("child queueTracker name",
childName))
- return false, false
- }
- removeQT, decreased :=
qt.childQueueTrackers[childName].decreaseTrackedResource(hierarchy[1:],
applicationID, usage, removeApp)
- if !decreased {
- return false, decreased
+ return false
Review Comment:
Uncovered branch. Will file a JIRA to enhance UT coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
