pbacsko commented on code in PR #810:
URL: https://github.com/apache/yunikorn-core/pull/810#discussion_r1545422827
##########
pkg/scheduler/ugm/manager.go:
##########
@@ -113,14 +113,14 @@ func (m *Manager) DecreaseTrackedResource(queuePath,
applicationID string, usage
zap.Bool("removeApp", removeApp))
if queuePath == common.Empty || applicationID == common.Empty || usage
== nil || user.User == common.Empty {
log.Log(log.SchedUGM).Debug("Mandatory parameters are missing
to decrease the resource usage")
- return false
+ return
}
userTracker := m.GetUserTracker(user.User)
if userTracker == nil {
log.Log(log.SchedUGM).Error("user tracker must be available in
userTrackers map",
zap.String("user", user.User))
- return false
+ return
Review Comment:
Will file a JIRA to address coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
