pbacsko commented on code in PR #810:
URL: https://github.com/apache/yunikorn-core/pull/810#discussion_r1545422578
##########
pkg/scheduler/ugm/group_tracker.go:
##########
@@ -48,20 +48,20 @@ func newGroupTracker(groupName string, events *ugmEvents)
*GroupTracker {
return groupTracker
}
-func (gt *GroupTracker) increaseTrackedResource(queuePath, applicationID
string, usage *resources.Resource, user string) bool {
+func (gt *GroupTracker) increaseTrackedResource(queuePath, applicationID
string, usage *resources.Resource, user string) {
if gt == nil {
- return true
+ return
}
gt.Lock()
defer gt.Unlock()
gt.events.sendIncResourceUsageForGroup(gt.groupName, queuePath, usage)
gt.applications[applicationID] = user
- return gt.queueTracker.increaseTrackedResource(strings.Split(queuePath,
configs.DOT), applicationID, group, usage)
+ gt.queueTracker.increaseTrackedResource(strings.Split(queuePath,
configs.DOT), applicationID, group, usage)
}
-func (gt *GroupTracker) decreaseTrackedResource(queuePath, applicationID
string, usage *resources.Resource, removeApp bool) (bool, bool) {
+func (gt *GroupTracker) decreaseTrackedResource(queuePath, applicationID
string, usage *resources.Resource, removeApp bool) bool {
if gt == nil {
- return false, true
+ return false
Review Comment:
Uncovered branch, will file a JIRA to address coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
