chenyulin0719 commented on code in PR #135:
URL: 
https://github.com/apache/yunikorn-scheduler-interface/pull/135#discussion_r1562926937


##########
go.mod:
##########
@@ -28,16 +28,16 @@ require (
 
 require (
        github.com/golang/protobuf v1.5.3 // indirect
-       golang.org/x/net v0.20.0 // indirect
-       golang.org/x/sys v0.17.0 // indirect

Review Comment:
   Hi @targetoee, 
   We don't manually change indirect dependency.
   
   However, `golang.org/x/sys v0.18.0 // indirect` could be kept since it was 
resovled by 'go mod tidy' after upgrade to golang.org/x/net v0.23.0.
   
   Here is our previous discussion for indirect/replacement
   - 
https://github.com/apache/yunikorn-k8shim/pull/794#pullrequestreview-1896062777
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to