craigcondit commented on code in PR #135:
URL:
https://github.com/apache/yunikorn-scheduler-interface/pull/135#discussion_r1564650225
##########
go.mod:
##########
@@ -28,16 +28,16 @@ require (
require (
github.com/golang/protobuf v1.5.3 // indirect
- golang.org/x/net v0.20.0 // indirect
- golang.org/x/sys v0.17.0 // indirect
Review Comment:
Except it doesn't work like that. The purpose of 'go mod tidy' is to remove
redundant information and 'tidy up' dependencies. We should never be committing
any go.mod / go.sum changes which go against what 'go mod tidy' produces,
otherwise every other user will have to undo work that it performs every time.
Those depended are indirect, and therefore not our responsibility. Instead we
use replacements to ensure that our own builds are forced to use newer
versions. Please do as Wilfred asks and leave these alone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
