chenyulin0719 commented on code in PR #135:
URL:
https://github.com/apache/yunikorn-scheduler-interface/pull/135#discussion_r1564662433
##########
go.mod:
##########
@@ -28,16 +28,16 @@ require (
require (
github.com/golang/protobuf v1.5.3 // indirect
- golang.org/x/net v0.20.0 // indirect
- golang.org/x/sys v0.17.0 // indirect
Review Comment:
Let me explain my thoughts step by step,
We changed ‘replace' directive to 'golang.org/x/net v0.23.0' first.
Then run 'go mod tidy' and it will automatilcally update 'golang.org/x/sys'
to v0.18.0. (**The minimum required version**)
Below is the tidy result:
<img width="993" alt="image"
src="https://github.com/apache/yunikorn-scheduler-interface/assets/26764036/f99494e8-78c1-4dee-8bc9-bb9d24fbf1af";>
Since 'replace' directive take higher precedence than indirect dependencies,
we should also change the 'replace' directive to 'golang.org/x/sys v0.18.0'.
(Otherwise Go will use the outdated version)
So the correct change for this PR is:
<img width="1032" alt="image"
src="https://github.com/apache/yunikorn-scheduler-interface/assets/26764036/d28501b8-98b3-4c59-9a87-70e0de7c1c93";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
